Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Updates for profile doc restructure #98301

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DOC] Updates for profile doc restructure #98301

wants to merge 2 commits into from

Conversation

knylander-grafana
Copy link
Collaborator

@knylander-grafana knylander-grafana commented Dec 20, 2024 •
edited
Loading

Updates the profiling doc:

  • Update intro content
  • Clarify changes for Explore Profiles related to Pyrscope

Which issue(s) does this PR fix?:

Relates to https://github.com/grafana/pyroscope-squad/issues/223

Blocked by grafana/pyroscope#3798 (shared files from this PR are required)

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@knylander-grafana knylander-grafana added type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project backport v11.4.x Mark PR for automatic backport to v11.4.x labels Dec 20, 2024
@knylander-grafana knylander-grafana added this to the 11.4.x milestone Dec 20, 2024
@knylander-grafana knylander-grafana self-assigned this Dec 20, 2024
@github-actions github-actions bot modified the milestones: 11.4.x, 11.5.x Dec 20, 2024
@knylander-grafana knylander-grafana mentioned this pull request Dec 20, 2024
Open
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

💻 Deploy preview available: https://deploy-preview-grafana-98301-zb444pucvq-vp.a.run.app/docs/grafana/latest/

@knylander-grafana knylander-grafana added the no-changelog Skip including change in changelog/release notes label Dec 20, 2024
lwandz13
lwandz13 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@lwandz13 lwandz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwandz13 lwandz13 lwandz13 approved these changes

Assignees

@knylander-grafana knylander-grafana

Labels
backport v11.4.x Mark PR for automatic backport to v11.4.x no-changelog Skip including change in changelog/release notes type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Milestone
11.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@knylander-grafana @lwandz13