Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle url from settings when filling the default query #1057

Merged
merged 3 commits into from
Nov 22, 2024
Merged

handle url from settings when filling the default query #1057

merged 3 commits into from
Nov 22, 2024

Conversation

yesoreyeram
Copy link
Collaborator

@yesoreyeram yesoreyeram commented Nov 20, 2024 •
edited
Loading

Fixes #908

also removed unused backend method QueryData and moved to _test package.

@yesoreyeram yesoreyeram requested a review from a team as a code owner November 20, 2024 12:47
@yesoreyeram yesoreyeram marked this pull request as draft November 20, 2024 12:47
@yesoreyeram yesoreyeram marked this pull request as ready for review November 21, 2024 07:56
zoltanbedi
zoltanbedi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ivanahuckova
ivanahuckova approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

pkg/models/query.go Show resolved Hide resolved
@ivanahuckova ivanahuckova merged commit 6565b85 into main Nov 22, 2024
6 checks passed
@ivanahuckova ivanahuckova deleted the fix/908 branch November 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@zoltanbedi zoltanbedi zoltanbedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base url not working as expected when there is no url in the query
3 participants
@yesoreyeram @zoltanbedi @ivanahuckova