Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin-sdk-go to version 255 #1004

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

zoltanbedi
Copy link
Member

@zoltanbedi zoltanbedi commented Oct 1, 2024

This pull request includes several updates to dependencies in the go.mod file and improvements to the AWS authentication handling in the pkg/infinity package. The key changes are as follows:

Dependency Updates:

  • go.mod: Updated multiple dependencies to their latest versions, including github.com/grafana/grafana-aws-sdk, golang.org/x/oauth2, and github.com/aws/aws-sdk-go among others. [1] [2] [3] [4] [5]

AWS Authentication Improvements:

  • pkg/infinity/client.go: Modified the NewClient function to handle errors when applying AWS authentication, logging an error message if AWS auth fails.
  • pkg/infinity/oauth.go: Updated the ApplyAWSAuth function to return an error if AWS auth settings are not found in the context, and to use the awsds.ReadAuthSettingsFromContext function for retrieving auth settings. [1] [2] [3]

To make sure that the AWS auth is still working I used https://grafana.com/docs/plugins/yesoreyeram-infinity-datasource/latest/examples/aws/ to set up the datasource and created an infinity-test user in aws.

@zoltanbedi zoltanbedi requested a review from a team as a code owner October 1, 2024 12:38
@zoltanbedi zoltanbedi self-assigned this Oct 1, 2024
pkg/infinity/oauth.go Outdated Show resolved Hide resolved
@zoltanbedi zoltanbedi changed the title Update plugin-sdk-go to version 251 Update plugin-sdk-go to version 252 Oct 15, 2024
Copy link

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you don't need to re-request review, but one comment about a change you should make.

pkg/infinity/oauth.go Outdated Show resolved Hide resolved
@zoltanbedi zoltanbedi force-pushed the bump-grafana-plugin-sdk-go-251 branch from 1d39f78 to 2a317c6 Compare October 17, 2024 14:20
@zoltanbedi zoltanbedi force-pushed the bump-grafana-plugin-sdk-go-251 branch from 2a317c6 to a19f637 Compare October 17, 2024 14:21
Copy link
Member

@gwdawson gwdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoltanbedi zoltanbedi changed the title Update plugin-sdk-go to version 252 Update plugin-sdk-go to version 255 Oct 17, 2024
@zoltanbedi zoltanbedi merged commit b40c48f into main Oct 17, 2024
6 checks passed
@zoltanbedi zoltanbedi deleted the bump-grafana-plugin-sdk-go-251 branch October 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants