-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin-sdk-go to version 255 #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
reviewed
Oct 9, 2024
zoltanbedi
changed the title
Update plugin-sdk-go to version 251
Update plugin-sdk-go to version 252
Oct 15, 2024
njvrzm
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you don't need to re-request review, but one comment about a change you should make.
zoltanbedi
force-pushed
the
bump-grafana-plugin-sdk-go-251
branch
from
October 17, 2024 14:20
1d39f78
to
2a317c6
Compare
zoltanbedi
force-pushed
the
bump-grafana-plugin-sdk-go-251
branch
from
October 17, 2024 14:21
2a317c6
to
a19f637
Compare
gwdawson
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zoltanbedi
changed the title
Update plugin-sdk-go to version 252
Update plugin-sdk-go to version 255
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to dependencies in the
go.mod
file and improvements to the AWS authentication handling in thepkg/infinity
package. The key changes are as follows:Dependency Updates:
go.mod
: Updated multiple dependencies to their latest versions, includinggithub.com/grafana/grafana-aws-sdk
,golang.org/x/oauth2
, andgithub.com/aws/aws-sdk-go
among others. [1] [2] [3] [4] [5]AWS Authentication Improvements:
pkg/infinity/client.go
: Modified theNewClient
function to handle errors when applying AWS authentication, logging an error message if AWS auth fails.pkg/infinity/oauth.go
: Updated theApplyAWSAuth
function to return an error if AWS auth settings are not found in the context, and to use theawsds.ReadAuthSettingsFromContext
function for retrieving auth settings. [1] [2] [3]To make sure that the AWS auth is still working I used https://grafana.com/docs/plugins/yesoreyeram-infinity-datasource/latest/examples/aws/ to set up the datasource and created an
infinity-test
user in aws.