Replace sharp with jimp #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturWierzbicki
force-pushed
the
replace-sharp-with-jimp
branch
from
e086086
to
02c5551
Compare
This was referenced Feb 23, 2022
Closed
This reverts commit d6bae5f.
Draft
AgnesToulet
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323
sharpis faster, but its native dependencies & our plugin mechanism don't work well together - at least for the time being. The numbers in sharp's benchmark seem scary, but it looks like it's not going to be an issue in our case - the numbers I posted in #314 remain unchanged.