Make the behavior of TypedStore.Update match the described behavior in the godoc
#595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the godoc with respect to ResourceVersion. If the ResourceVersion is empty, return an error, and otherwise always pass the ResourceVersion to the underlying UpdateOptions.
radiohead
approved these changes
Jan 20, 2025
IfSentient
added a commit
that referenced
this pull request
Jan 21, 2025
… in the godoc (#604) Make the behavior of `TypedStore.Update` match the described behavior in the godoc with respect to ResourceVersion. If the ResourceVersion is empty, return an error, and otherwise always pass the ResourceVersion to the underlying UpdateOptions. Duplicate of #595 applied to the LTS branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the behavior of
TypedStore.Updatematch the described behavior in the godoc with respect to ResourceVersion. If the ResourceVersion is empty, return an error, and otherwise always pass the ResourceVersion to the underlying UpdateOptions.