Deprecate simple.NewOperator and update examples
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of simple.Operator usage.
toddtreece
reviewed
Jan 6, 2025
| String string `json:"stringField"` | ||
| } | ||
|
|
||
| func NewApp(config app.Config) (app.App, error) { | ||
| // Set up the watcher | ||
| watcher := &simple.Watcher{ |
There was a problem hiding this comment.
@radiohead mentioned that a reconciler was preferred over a watcher. if so, should the watcher be switched for a reconciler as well?
There was a problem hiding this comment.
We have an example for each right now, I don't know if we want to remove the watcher examples completely yet (especially since codegen still builds a watcher by default at the moment)
toddtreece
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deprecation comment to
simple.NewOperatorandsimple.Operator.examples/operator/simplewas still usingsimple.Operator, so the code has been updated to usesimple.Appandoperator.Runner.examples/operator/opinionatedwas building an operator from scratch, which is no longer advised, so the example has been removed.