[codegen] Generate exported constants for group and version. #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charandas
reviewed
Jan 6, 2025
codegen/cuekind/generators_test.go
Outdated
| @@ -60,8 +60,8 @@ func TestResourceGenerator(t *testing.T) { | |||
| files, err := ResourceGenerator(false).Generate(kinds...) | |||
| require.Nil(t, err) | |||
| // Check number of files generated | |||
| // 12 (6 -> object, spec, metadata, status, schema, codec) * 2 versions | |||
| assert.Len(t, files, 12) | |||
| // 14 (6 -> object, spec, metadata, status, schema, codec, constants) * 2 versions | |||
There was a problem hiding this comment.
Suggested change
| // 14 (6 -> object, spec, metadata, status, schema, codec, constants) * 2 versions | |
| // 14 (7 -> object, spec, metadata, status, schema, codec, constants) * 2 versions |
charandas
reviewed
Jan 6, 2025
codegen/cuekind/generators_test.go
Outdated
| @@ -70,8 +70,8 @@ func TestResourceGenerator(t *testing.T) { | |||
| files, err := ResourceGenerator(true).Generate(kinds...) | |||
| require.Nil(t, err) | |||
| // Check number of files generated | |||
| // 12 (6 -> object, spec, metadata, status, schema, codec) * 2 versions | |||
| assert.Len(t, files, 12) | |||
| // 14 (6 -> object, spec, metadata, status, schema, codec, constants) * 2 versions | |||
There was a problem hiding this comment.
Suggested change
| // 14 (6 -> object, spec, metadata, status, schema, codec, constants) * 2 versions | |
| // 14 (7 -> object, spec, metadata, status, schema, codec, constants) * 2 versions |
charandas
approved these changes
Jan 6, 2025
radiohead
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate exported
Group,Version, andGroupVersionconstants for each generated kind's package (when grouping kinds by version, only one set of constants will be generated for the package). This allows for a more convenient way to reference these constants vs. using the Kind accessor method, and then getting its Group/Version, especially when kinds are grouped by version, so multiple kinds are in the same package, sharing the same constants.This is implemented as a new generated file because it has to be generated only once per package, unlike the other kind files which exist once per kind.
Resolves #515