Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #215

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update docs #215

merged 1 commit into from
Sep 13, 2024

Conversation

nmarrs
Copy link
Contributor

@nmarrs nmarrs commented Sep 5, 2024

Not sure if this the correct docs to link to here.

Maybe instead we need to also update the naming in the grafana docs first and then update these links accordingly? Happy to take that on if that is the case 👍

Fixes #182

@nmarrs nmarrs self-assigned this Sep 5, 2024
@nmarrs nmarrs requested a review from a team as a code owner September 5, 2024 19:11
@nmarrs nmarrs requested review from idastambuk and kevinwcyu and removed request for a team September 5, 2024 19:11
@nmarrs nmarrs added the documentation Improvements or additions to documentation label Sep 5, 2024
@nmarrs nmarrs requested a review from njvrzm September 5, 2024 19:12
Copy link
Contributor

@idastambuk idastambuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "update naming"? Maybe it would be enough to just link the AMP docs from the main Prometheus docs 🤔

Copy link
Collaborator

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine for now! 👍🏻

@nmarrs nmarrs merged commit 47789c5 into main Sep 13, 2024
6 checks passed
@nmarrs nmarrs deleted the update-docs branch September 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation links in config editor
3 participants