Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix syntax in Dockerfile #207

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: fix syntax in Dockerfile #207

merged 1 commit into from
Oct 23, 2024

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Oct 23, 2024

Fixes the https://docs.docker.com/reference/build-checks/json-args-recommended/ build check warning. This also slightly changes the semantics of the call as the Go binary is now directly PID 1 instead of going through an implicit shell, but this shouldn't be an issue IMO.

@zerok zerok requested review from julienduchesne and a team as code owners October 23, 2024 11:14
@zerok zerok merged commit 6c731e4 into main Oct 23, 2024
7 checks passed
@zerok zerok deleted the zerok/clean-docker-build-check branch October 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants