-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add validation Github Action for docs PRs #59
Conversation
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not fully sure about the implications for the docs in docs/sources
and other validations/builds docs/Makefile`. Are we even building the docs as part of a PR?
But gnerally agree with enforcing this
We should build docs as part of the PR check if the PR has doc changes like we do in the Pyroscope repo. Our build process doesn't use any docs outside of docs/sources, so the linter should only run on those items. If you have specific questions, I can ask Jack Baldry and find out for you.
For reference, doc linter info: (https://grafana.com/docs/writers-toolkit/review/lint-prose/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, most looks good to me
779e560
Since Jack has already reviewed, I'll defer to his comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs related CI and DX look good to me
# Conflicts: # docs/sources/_index.md
@jdbaldry I've fixed some conflicts, may I ask you a final review? 🙏🏾 Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✨ Description
Related issue(s): resolves #62
This PR:
📖 Summary of the changes
See diff tab
🧪 How to test?