perf(*): Lazy load page components #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
force-pushed
the
grafakus/lazy-load-pages
branch
from
36bd145 to
42fecf6
Compare
grafakus
changed the title
grafakus
changed the title
This reverts commit 7575cdf.
|
Would it actually solve the problem? Do you have more details on why the previous attempt failed? I tried running the previous version in dev and worked fine 🤔 (see also #323 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): #322, 2nd attempt
The 1st attempt resulted in a runtime error. See my question in Slack for more context.
📖 Summary of the changes
See diff tab
🧪 How to test?