perf(Series): Limit the number of series request by breakdown charts #219
+181
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
changed the title
grafakus
commented
Oct 10, 2024
| @@ -38,18 +35,3 @@ export const addStats = () => (source: Observable<DataFrame[]>) => | |||
| }); | |||
| }) | |||
| ); | |||
|
|
|||
# Conflicts: # src/pages/ProfilesExplorerView/components/SceneExploreServiceLabels/components/SceneGroupByLabels/components/SceneLabelValuesGrid/SceneLabelValuesGrid.tsx
3 tasks
bryanhuhta
previously approved these changes
Nov 7, 2024
|
@ifrost in which Grafana version can we expect the changes grafana/grafana#95780 to be integrated? Next week? 11.3.0-xyz? Sorry I'm still not familiar with the world of Grafana's rolling releases 😅 |
# Conflicts: # src/pages/ProfilesExplorerView/domain/actions/SelectAction.tsx
grafakus
force-pushed
the
perf/limit-series-breakdown-charts
branch
from
092a7bd to
fd24b38
Compare
grafakus
commented
Dec 10, 2024
drone_migration.yaml
Outdated
| @@ -2,421 +2,421 @@ | |||
| name: build packages | |||
| services: [] | |||
| steps: | |||
| - commands: | |||
# Conflicts: # docker-compose.e2e.yaml # docker-compose.local.yaml # docker-compose.remote.yaml # docker-compose.yaml # package.json # src/pages/ProfilesExplorerView/components/SceneLabelValuesTimeseries/SceneLabelValuesTimeseries.tsx # src/plugin.json # src/shared/infrastructure/tracking/faro/__tests__/faro.spec.ts # yarn.lock
ifrost
reviewed
Jan 7, 2025
| @@ -7,7 +7,7 @@ | |||
| "backend": false, | |||
| "preload": true, | |||
| "dependencies": { | |||
| "grafanaDependency": ">=11.3.2", | |||
| "grafanaDependency": ">=11.4.0", | |||
There was a problem hiding this comment.
Suggested change
| "grafanaDependency": ">=11.4.0", | |
| "grafanaDependency": ">=11.5.0", |
@ifrost in which Grafana version can we expect the changes grafana/grafana#95780 to be integrated? Next week? 11.3.0-xyz?
Sorry I'm still not familiar with the world of Grafana's rolling releases 😅
It will be out 15 January in 11.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
package.jsonto use Grafana 11.5.0 once it's publishedRelated issue(s): resolves #192, was blocked by grafana/grafana#95780, which is merged and deployed to all channels:
📖 Summary of the changes
This PR replaces the custom data transformations of the time series. Instead, a new
limitparameter is passed when fetching from the API.🧪 How to test?
On the "Labels" view, the max number of series received by the API is limited to 10 ; the page loads faster (which can also be verified by checking the requests in the "Network" tab of the browser's devtools)