Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Show log text not preserved in URL state #979

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Table: Show log text not preserved in URL state #979

merged 2 commits into from
Jan 6, 2025

Conversation

gtk-grafana
Copy link
Contributor

Fixes: #977

@gtk-grafana gtk-grafana requested a review from a team as a code owner January 3, 2025 20:56
@gtk-grafana gtk-grafana self-assigned this Jan 3, 2025
@gtk-grafana gtk-grafana added the enhancement New feature or request label Jan 3, 2025
@gtk-grafana gtk-grafana added this to the 1.0.5 milestone Jan 3, 2025
@matyax
Copy link
Contributor

matyax commented Jan 6, 2025 •
edited
Loading

I wasn't aware of the "show log text" / "show labels" option until this PR.

matyax
matyax reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the issue. Left a comment about the new URL parameter.

matyax
matyax approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GW!

@gtk-grafana gtk-grafana merged commit 5a54b9c into main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gtk-grafana gtk-grafana

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

Table: Show log text not preserved in URL state
2 participants
@gtk-grafana @matyax