Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go to explore button, add PanelMenu to logs & table panels #942

Merged
merged 37 commits into from
Dec 10, 2024
Merged

Remove go to explore button, add PanelMenu to logs & table panels #942

merged 37 commits into from
Dec 10, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Dec 9, 2024 •
edited
Loading

Fixes: #933

Remove this button:
image

Add PanelMenu instead:
image

@todo:
✅ Disable investigations links for these panels

  • Looks like investigations doesn't support non timeseries data yet (logs/table data)
  • Table has a weird bug with the useResizeObserver when investigations drawer is opened (this is present on main)

gtk-grafana and others added 28 commits December 3, 2024 08:59
@gtk-grafana
feat: rearrange menus and add new single panel above breakdowns
d76456d
@gtk-grafana
chore: fix search
9b48adf
@gtk-grafana
feat: add summary timeseries to label values breakdown
6518e13
@gtk-grafana
chore: refactor variable methods into new file
58d4d8d
@gtk-grafana
test: fix e2e assertions
0203e58
@gtk-grafana
test: fix flakey test
9fd65e2
@gtk-grafana
chore: remove only
e24225e
@gtk-grafana
chore: sync text search state
530cee0
@gtk-grafana
feat: make panel collapsible
8285424
@gtk-grafana
chore: wip - refactoring series limit
4cbb0e5
@gtk-grafana
chore: add limit to summary panel
c086f61
@gtk-grafana
chore: unused import
cdbb9f2
@gtk-grafana
Merge remote-tracking branch 'origin/main' into gtk-grafana/issues/86…
58bd00b 
…2/drilldown-values-ui-updates
@gtk-grafana
chore: clean up, add series limit to summary panel
d32818e
@gtk-grafana
chore: update collapsed
2300cea
@gtk-grafana
chore: refactor collapsable states in panel menus
b87efa6
@gtk-grafana
chore: add findObjectOfType scenes helper method, remove type assertions
7f64aa3
@gtk-grafana
chore: remove unused import
01677e9
@gtk-grafana
chore: remove css hack
29065c0
@gtk-grafana
chore: make spacing consistent
67fcbaa
@gtk-grafana
chore: remove search from aggregation scene, fix summary panel filtering
114b699
@gtk-grafana
chore: revert 11.4 updates
82a4ffb
@gtk-grafana
chore: remove 11.4 deps, update comments
8534542
@gtk-grafana
chore: add e2e coverage
982d83e
@gtk-grafana
Merge branch 'main' into gtk-grafana/issues/862/drilldown-values-ui-u…
7c59a8b 
…pdates
@gtk-grafana
chore: revert yarn.lock
afa5ae8
@gtk-grafana
chore: remove go to explore button, add PanelMenus to logs and table …
34378be 
…panels
@gtk-grafana
chore: remove explorations link for logs/table panels
e9b9d71
@gtk-grafana gtk-grafana added this to the 1.0.5 milestone Dec 9, 2024
@gtk-grafana gtk-grafana added enhancement New feature or request and removed chore labels Dec 9, 2024
@gtk-grafana gtk-grafana self-assigned this Dec 9, 2024
@gtk-grafana gtk-grafana marked this pull request as ready for review December 9, 2024 18:20
@gtk-grafana gtk-grafana requested a review from a team as a code owner December 9, 2024 18:20
gtk-grafana and others added 2 commits December 9, 2024 14:45
@gtk-grafana
Merge branch 'main' into gtk-grafana/issues/862/drilldown-values-ui-u…
7e548d6 
…pdates
@gtk-grafana
Merge remote-tracking branch 'origin/gtk-grafana/issues/862/drilldown…
0cb621a 
…-values-ui-updates' into gtk-grafana/issues/933/open-in-explore-button-panel-headers
Base automatically changed from gtk-grafana/issues/862/drilldown-values-ui-updates to main December 10, 2024 14:41
@gtk-grafana gtk-grafana merged commit 58ce56e into main Dec 10, 2024
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/933/open-in-explore-button-panel-headers branch December 10, 2024 16:51
shantanualsi pushed a commit that referenced this pull request Dec 17, 2024
@gtk-grafana @shantanualsi
Remove go to explore button, add PanelMenu to logs & table panels (#942)
3ea4cb5 
feat: remove explore button, add panel menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gtk-grafana gtk-grafana

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

"Open in explore" button should be moved to the logs panel header?
2 participants
@gtk-grafana @matyax