-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ring: working example on using ring
package
#272
Conversation
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Update README Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
@kavirajk thanks a lot for this usefull example. It help me a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments, mainly the ones for ring/example/local/README.md :)
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please see nits. Also the build needs fixing :)
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
What this PR does:
An example to show case the usage of ring package. We build a small cluster of process using local "loopback" interface.
Going forward I wanted to add another example to use it with k8.
Which issue(s) this PR fixes:
Related: #267
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]