Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gopsutil library to v3 #884

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

mariomac
Copy link
Contributor

With the ongoing implementation of process sampling, updating Gopsutil to v3 also for the other components, so we work with the same latest version of the library in all the components using that library.

@mariomac mariomac requested review from grcevski and marctc as code owners May 27, 2024 08:44
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (81f5453) to head (5707d6a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   79.78%   79.73%   -0.05%     
==========================================
  Files         117      117              
  Lines        8060     8060              
==========================================
- Hits         6431     6427       -4     
- Misses       1225     1227       +2     
- Partials      404      406       +2     
Flag Coverage Δ
integration-test 56.37% <ø> (-0.03%) ⬇️
k8s-integration-test 65.06% <ø> (-0.02%) ⬇️
oats-test 35.94% <ø> (ø)
unittests 46.29% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 8cb1510 into grafana:main May 28, 2024
6 checks passed
@mariomac mariomac deleted the gopsutil-v3 branch May 28, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants