Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes filter network documentation (1.6 backport) #863

Merged
merged 1 commit into from
May 23, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented May 23, 2024

Backport of (#861)

Backport of (grafana#861)

* Fix documentation

* Fix unit test

* Edit

---------

Co-authored-by: Sean Packham <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (c48b336) to head (0ac2fe0).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.6     #863       +/-   ##
================================================
- Coverage        79.72%   61.80%   -17.93%     
================================================
  Files              117      117               
  Lines             8058     8058               
================================================
- Hits              6424     4980     -1444     
- Misses            1228     2717     +1489     
+ Partials           406      361       -45     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test 35.61% <ø> (ø)
unittests 46.19% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 6400ede into grafana:release-1.6 May 23, 2024
9 of 10 checks passed
@mariomac mariomac deleted the fix-docs-16 branch May 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants