Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update K8s documentation with the daemonset/replicaset/statefulset selectors and labels #575

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Update K8s documentation with the daemonset/replicaset/statefulset selectors and labels #575

merged 1 commit into from
Jan 26, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac requested a review from grcevski as a code owner January 25, 2024 13:45
@mariomac mariomac requested a review from grafsean January 25, 2024 14:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (959bc86) 79.04% compared to head (128b51e) 68.79%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #575       +/-   ##
===========================================
- Coverage   79.04%   68.79%   -10.26%     
===========================================
  Files          70       67        -3     
  Lines        5903     5787      -116     
===========================================
- Hits         4666     3981      -685     
- Misses       1009     1522      +513     
- Partials      228      284       +56
Flag Coverage Δ
integration-test 68.79% <ø> (+0.08%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grcevski
grcevski approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 1b9bbd7 into grafana:main Jan 26, 2024
6 checks passed
@mariomac mariomac deleted the k8s-update-docs branch January 26, 2024 08:45
@github-actions GitHub Actions
Copy link
Contributor

Hello @jdbaldry!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

github-actions bot pushed a commit that referenced this pull request Jan 26, 2024
@mariomac @grafana-delivery-bot
Update K8s documentation with the daemonset/replicaset/statefulset se…
1cc4191 
…lectors and labels (#575)

(cherry picked from commit 1b9bbd7)
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Merged
mariomac added a commit that referenced this pull request Jan 26, 2024
@github-actions @mariomac
Update K8s documentation with the daemonset/replicaset/statefulset se…
992041d 
…lectors and labels (#575) (#576)

(cherry picked from commit 1b9bbd7)

Co-authored-by: Mario Macias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafsean grafsean grafsean approved these changes

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
backport release-1.2 backport-1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mariomac @codecov-commenter @grcevski @grafsean @jdbaldry