Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s tutorial: add extra steps for trace visualization #561

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac requested a review from grafsean January 19, 2024 09:29
@mariomac mariomac requested a review from grcevski as a code owner January 19, 2024 09:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72a0ed9) 79.94% compared to head (a14b1e8) 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   79.94%   80.00%   +0.05%     
==========================================
  Files          69       69              
  Lines        5830     5830              
==========================================
+ Hits         4661     4664       +3     
+ Misses        946      944       -2     
+ Partials      223      222       -1     
Flag Coverage Δ
integration-test 69.81% <ø> (+0.24%) ⬆️
unittests 45.04% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mario! I copy edited, ready to go LGTM 😄

@grafsean grafsean merged commit 2dda54b into grafana:main Jan 19, 2024
5 checks passed
@mariomac mariomac deleted the k8s-tut-extra-steps branch January 19, 2024 14:49
mariomac added a commit to mariomac/beyla that referenced this pull request Jan 19, 2024
grafsean added a commit that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants