Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track clones for context propagation #560

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Jan 18, 2024

This change helps us track server->client inside a process when the applications use real threads for this. Some examples might include Java SpringBoot using spring RestClient and Rust Actix using reqwest.

The idea is exactly the same as how we track the goroutine parent -> child relationships, except we here track sys_clone and sys_exit.

TODO:

  • Integration tests

@grcevski grcevski requested a review from mariomac as a code owner January 18, 2024 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (72a0ed9) 79.94% compared to head (0af5fb6) 45.02%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/internal/ebpf/httpfltr/httpfltr.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #560       +/-   ##
===========================================
- Coverage   79.94%   45.02%   -34.93%     
===========================================
  Files          69       67        -2     
  Lines        5830     5664      -166     
===========================================
- Hits         4661     2550     -2111     
- Misses        946     2964     +2018     
+ Partials      223      150       -73     
Flag Coverage Δ
integration-test ?
unittests 45.02% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@grcevski grcevski merged commit 7c37178 into grafana:main Jan 22, 2024
4 checks passed
@grcevski grcevski deleted the track_clones branch January 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants