Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation in Mac #1528

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix compilation in Mac #1528

merged 1 commit into from
Jan 14, 2025

Conversation

mariomac
Copy link
Contributor

No description provided.

@mariomac mariomac requested a review from a team as a code owner January 14, 2025 15:28
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (02c626b) to head (e8f55ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/export/prom/prom_bpf_linux.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   73.41%   73.46%   +0.04%     
==========================================
  Files         191      192       +1     
  Lines       18809    18813       +4     
==========================================
+ Hits        13809    13821      +12     
+ Misses       4335     4328       -7     
+ Partials      665      664       -1     
Flag Coverage Δ
integration-test 55.07% <50.00%> (-0.02%) ⬇️
k8s-integration-test 56.09% <50.00%> (+0.22%) ⬆️
oats-test 31.22% <0.00%> (-0.01%) ⬇️
unittests 48.56% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 3baaf5c into grafana:main Jan 14, 2025
13 checks passed
@mariomac mariomac deleted the fix-mac branch January 14, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants