Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump metrics and traces on file after integration tests #1521

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

mariomac
Copy link
Contributor

There are some flaky tests that are difficult to debug because they seem impossible to reproduce locally.

This PR dumps the contents of the prometheus and jaeger storages before a cluster is being shutdown. This way we can diagnose better what is missing in the metrics or traces, if a test fail.

@mariomac mariomac requested a review from a team as a code owner January 13, 2025 15:04
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (f0bb669) to head (28637d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
- Coverage   73.32%   73.27%   -0.05%     
==========================================
  Files         190      190              
  Lines       18647    18647              
==========================================
- Hits        13672    13664       -8     
- Misses       4318     4323       +5     
- Partials      657      660       +3     
Flag Coverage Δ
integration-test 54.78% <ø> (-0.02%) ⬇️
k8s-integration-test 55.75% <ø> (-0.01%) ⬇️
oats-test 31.45% <ø> (ø)
unittests 48.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! much needed!

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mariomac mariomac merged commit 83bd4f6 into grafana:main Jan 13, 2025
13 checks passed
@mariomac mariomac deleted the dump-metrics-traces branch January 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants