Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Beyla if either NetO11y or AppO11y component fails [1.9-backport] #1520

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mariomac
Copy link
Contributor

backport of #1519

Addresses #1514

@mariomac mariomac marked this pull request as ready for review January 13, 2025 11:48
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (06d9d25) to head (e23b6d4).
Report is 1 commits behind head on release-1.9.

Files with missing lines Patch % Lines
pkg/components/beyla.go 50.00% 4 Missing ⚠️
pkg/internal/discover/watcher_proc.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1520      +/-   ##
===============================================
- Coverage        81.07%   81.06%   -0.02%     
===============================================
  Files              146      146              
  Lines            14843    14854      +11     
===============================================
+ Hits             12034    12041       +7     
- Misses            2219     2223       +4     
  Partials           590      590              
Flag Coverage Δ
integration-test 58.31% <18.18%> (-0.06%) ⬇️
k8s-integration-test 60.13% <18.18%> (+0.10%) ⬆️
oats-test 33.86% <18.18%> (-0.02%) ⬇️
unittests 51.65% <36.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 568a53a into release-1.9 Jan 13, 2025
15 checks passed
@mariomac mariomac deleted the stop-beyla-19 branch January 13, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants