No trace #1489
Open
No trace #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no; functional change
…e id field, set the parent span id to zero
…er name will change to ck-route but the value right now will be same
…iting traceparent
…e literal value, keeping length same
…ck encoding as provided by cursor
…nly; value remains same format as of now
… format, key as ck-route
Priyanka-CKT
requested review from
grcevski,
mariomac,
marctc and
rafaelroquetto
as code owners
|
|
|
Hi @Priyanka-CKT, thanks for making this PR, looks like you are trying to replace the |
|
@Priyanka-CKT in order to make life of reviewers easier, I encourage you to add a Description to PR and a more meaningful PR title. Thanks! 🙏 |
…n write headers func only
…ll pass 32 char len header and output also 32 len header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.