Isolate BPF_TRACEPARENT macro #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
==========================================
+ Coverage 72.83% 81.16% +8.32%
==========================================
Files 148 149 +1
Lines 15312 15321 +9
==========================================
+ Hits 11153 12435 +1282
+ Misses 3424 2269 -1155
+ Partials 735 617 -118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rafaelroquetto
requested review from
grcevski,
mariomac and
marctc
as code owners
rafaelroquetto
force-pushed
the
bpf_traceparent
branch
from
8956a8f to
7c6d1f8
Compare
rafaelroquetto
force-pushed
the
bpf_traceparent
branch
from
7c6d1f8 to
1b5b802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace macro with a constant so that the entire code is always sieved through the compiler, ensuring the code is legal at all times.
The compiler will optimise out the dead code even with
-O0.