Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing check for ignored metrics for Prometheus export #1441

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

grcevski
Copy link
Contributor

Our prometheus export loop didn't check the filtering setup in the config, the OTel loop does.

Closes #1435

I'll back-port this to 1.9 and 1.8

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (a6d91fd) to head (11f371a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   76.90%   80.95%   +4.04%     
==========================================
  Files         149      149              
  Lines       15250    15252       +2     
==========================================
+ Hits        11728    12347     +619     
+ Misses       2906     2299     -607     
+ Partials      616      606      -10     
Flag Coverage Δ
integration-test 59.82% <100.00%> (-0.03%) ⬇️
k8s-integration-test 60.38% <100.00%> (?)
oats-test 33.91% <0.00%> (-0.01%) ⬇️
unittests 51.96% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 85b6cdd into grafana:main Dec 10, 2024
13 checks passed
@grcevski grcevski deleted the prom_ignore_metrics branch December 10, 2024 17:49
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routes ignored_patterns option fails to filter metrics
2 participants