Fix bpf_printk only accept three parameter #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomatopunk
requested review from
grcevski,
mariomac,
marctc and
rafaelroquetto
as code owners
|
|
|
CC @grcevski . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
+ Coverage 76.90% 80.97% +4.06%
==========================================
Files 149 149
Lines 15250 15250
==========================================
+ Hits 11728 12348 +620
+ Misses 2906 2297 -609
+ Partials 616 605 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
approved these changes
Dec 10, 2024
grcevski
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM! Thanks for your contribution @tomatopunk!
We'll update the BPF binaries on a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
In the PR, I've fixed a bug related to the use of bpf_printk. Since bpf_printk can only accept a maximum of three arguments, I split it into two lines.