Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export internal metrics using OTEL metrics #1425
base: main
Are you sure you want to change the base?
Export internal metrics using OTEL metrics #1425
Changes from 1 commit
87b3e7a
80415fc
51f8cd4
6dfbb40
4e0313b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to be less redundant, rename YAML property to
otel
oruse_otel
and the env var toBEYLA_INTERNAL_METRICS_OTEL
orBEYLA_INTERNAL_METRICS_USE_OTEL
?Even, to rely less on booleans for config, replace this property for something like
protocol
orexporter
, which can benone
,prometheus
orotel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not a bad idea, but that would imply breaking changes, no? basically we have to force everyone to set
exporter
andprometheus
config for internal metrics.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can document that breaking change in Beyla 2.0.
If we want to keep backwards compatibility, maybe we could default it to
prometheus
, and explain that it will only have effect if theprometheus
subsection is set.But anyway that was just a suggestion. I'm fine with current implementation.