Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky unit tests #1421

Merged
merged 2 commits into from
Dec 1, 2024
Merged

fix flaky unit tests #1421

merged 2 commits into from
Dec 1, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Nov 29, 2024

There is still a small chance that TestTraceSampling fails, as it's just a probabilistic matter. But should greatly reduce the frequency of failure.

Also fixes TestSpanAttributeFilterNode, which wrongly assumed that two consecutive metric reports would belong to different entities.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (77046c4) to head (1817516).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   72.30%   80.86%   +8.56%     
==========================================
  Files         145      146       +1     
  Lines       14893    14925      +32     
==========================================
+ Hits        10768    12069    +1301     
+ Misses       3405     2265    -1140     
+ Partials      720      591     -129     
Flag Coverage Δ
integration-test 59.02% <ø> (-0.10%) ⬇️
k8s-integration-test 59.86% <ø> (-0.18%) ⬇️
oats-test 33.90% <ø> (-0.08%) ⬇️
unittests 51.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac changed the title fix flaky unit test fix flaky unit tests Nov 29, 2024
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 4ca0c48 into grafana:main Dec 1, 2024
13 checks passed
@mariomac mariomac deleted the fix-flaky-unit branch December 1, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants