Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Restore cpu efficient cache #1379

Closed
wants to merge 3 commits into from

Conversation

mariomac
Copy link
Contributor

Restore the CPU-efficient cache that was reverted in: #1362

This PR is still not ready to be merged. It introduced a memory leak that we haven't been yet able to manually reproduce and fix.

@mariomac mariomac added the do-not-merge WIP or something that musn't be merged label Nov 19, 2024
@mariomac mariomac changed the title Restore cpu efficient cache WIP: Restore cpu efficient cache Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (d19600e) to head (9bc246a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kubecache/service/service.go 93.75% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   72.36%   78.55%   +6.18%     
==========================================
  Files         145      146       +1     
  Lines       14722    14767      +45     
==========================================
+ Hits        10654    11600     +946     
+ Misses       3359     2565     -794     
+ Partials      709      602     -107     
Flag Coverage Δ
integration-test ?
k8s-integration-test 59.89% <75.00%> (-0.10%) ⬇️
oats-test 34.10% <ø> (ø)
unittests 51.98% <93.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac
Copy link
Contributor Author

Giving up with this approach.

@mariomac mariomac closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge WIP or something that musn't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant