Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke nodejs uretprobes #1305

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Nuke nodejs uretprobes #1305

merged 1 commit into from
Oct 31, 2024

Conversation

rafaelroquetto
Copy link
Contributor

These uretprobes are causing nodejs to segfault on newer Linux kernels. They are not strictly required, so we can simply do without them.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (eb0a8c4) to head (52e8941).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (eb0a8c4) and HEAD (52e8941). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (eb0a8c4) HEAD (52e8941)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   81.25%   72.51%   -8.74%     
==========================================
  Files         142      141       -1     
  Lines       14294    14283      -11     
==========================================
- Hits        11614    10357    -1257     
- Misses       2116     3239    +1123     
- Partials      564      687     +123     
Flag Coverage Δ
integration-test 58.78% <ø> (-0.14%) ⬇️
k8s-integration-test 59.53% <ø> (+0.12%) ⬆️
oats-test 35.04% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelroquetto rafaelroquetto merged commit b23d4ca into main Oct 31, 2024
15 checks passed
@rafaelroquetto rafaelroquetto deleted the fix_nodejs_retprobes branch October 31, 2024 22:31
@grcevski grcevski mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants