Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options to Kube Cache service #1304

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mariomac
Copy link
Contributor

Prior to dogfooding, this PR adds some extra configuration options to the service.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 40.98361% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (916fd95) to head (0ea41b8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/k8s-cache/main.go 39.02% 19 Missing and 6 partials ⚠️
pkg/kubecache/config.go 21.42% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   80.54%   80.45%   -0.10%     
==========================================
  Files         141      142       +1     
  Lines       14217    14262      +45     
==========================================
+ Hits        11451    11474      +23     
- Misses       2225     2242      +17     
- Partials      541      546       +5     
Flag Coverage Δ
integration-test 58.75% <ø> (-0.03%) ⬇️
k8s-integration-test 58.38% <40.98%> (-0.06%) ⬇️
oats-test 35.01% <ø> (-0.01%) ⬇️
unittests 52.44% <9.83%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit bce5cf4 into grafana:main Oct 31, 2024
13 checks passed
@mariomac mariomac deleted the cfg-cache-svc branch October 31, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants