Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8s metadata cache service to helm chart #1296

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

mariomac
Copy link
Contributor

To enable it, just add this section to the values.yml:

k8sCache:
  replicas: 1
  image:
    tag: main

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (56e5b9b) to head (0b5d2a8).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   80.56%   80.62%   +0.06%     
==========================================
  Files         141      141              
  Lines       14217    14217              
==========================================
+ Hits        11454    11463       +9     
+ Misses       2223     2215       -8     
+ Partials      540      539       -1     
Flag Coverage Δ
integration-test 58.79% <ø> (+0.02%) ⬆️
k8s-integration-test 58.56% <ø> (+0.06%) ⬆️
oats-test 34.99% <ø> (-0.03%) ⬇️
unittests 52.59% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 8af4fab into grafana:main Nov 4, 2024
13 checks passed
@mariomac mariomac deleted the helm-chart branch November 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants