Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network flows flaky test #1282

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

mariomac
Copy link
Contributor

To speedup network flows testing, we were reusing the internal-pinger pod from a previous test, however, depending on the order of the events, the test might fail:

  1. Internal-pinger is deployed.
  2. The app o11y pipeline gets the internal-pinger metadata.
  3. Internal pinger sends a ping.
  4. Net o11y pipeline detects the packet before it gets the Pod metadata from the informer (it works in another thread than app o11y), so reports it without metadata.
  5. The app o11y pipeline detects the call and sends it properly decorated.
  6. The app o11y HTTP test succeeds and internal-pinger is removed.
  7. The Net O11y integration test is run, assuming that the net pipeline should have detected the flow in the previous HTTP test.
  8. The Net O11y integration test fails, because the flow was detected but not properly decorated with the internal-pinger metadata.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (4f7e880) to head (6229a87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
- Coverage   80.22%   80.21%   -0.01%     
==========================================
  Files         140      140              
  Lines       14058    14058              
==========================================
- Hits        11278    11277       -1     
+ Misses       2242     2241       -1     
- Partials      538      540       +2     
Flag Coverage Δ
integration-test 59.26% <ø> (-0.02%) ⬇️
k8s-integration-test 57.71% <ø> (+0.02%) ⬆️
oats-test 35.25% <ø> (ø)
unittests 52.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 71a0767 into grafana:main Oct 29, 2024
11 of 12 checks passed
@mariomac mariomac deleted the fix-netflow-flaky branch October 29, 2024 14:01
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants