flaky language detection test: add extra logs #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
mariomac
commented
Oct 26, 2024
| URL string | ||
| Host string | ||
| Peer string | ||
| Service svc.ID |
There was a problem hiding this comment.
This field was set, but never read outside the unit tests. Deleting it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
+ Coverage 77.80% 80.63% +2.83%
==========================================
Files 133 133
Lines 13596 13600 +4
==========================================
+ Hits 10578 10967 +389
+ Misses 2488 2121 -367
+ Partials 530 512 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the logs of the tests that fail because Beyla does not properly seem to detect the language, I observe that actually the language is correctly detected.
However, at some point, the
svc.ID.SDKLanguagefield is not properly copied along with the rest of thesvc.IDstruct, then its value remains to0, which was the value ofInstrumentableGolang.This PR just adds extra logging information to try to see where this might be failing.