Enabling external informer #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
+ Coverage 80.42% 80.55% +0.13%
==========================================
Files 132 133 +1
Lines 13535 13596 +61
==========================================
+ Hits 10885 10952 +67
+ Misses 2133 2129 -4
+ Partials 517 515 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
mariomac
requested review from
grcevski,
rafaelroquetto and
marctc
and removed request for
rafaelroquetto,
marctc and
grcevski
grcevski
approved these changes
Oct 24, 2024
|
LGTM! Good stuff! |
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* enabling external informer * preparing integration tests * Fixed tests * almost-working tests with external cache * specifying cache port in integration tests * updating beyla-k8s-cache library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function enables a new configuration option that allows switching from the local Kube API informer client to a gRPC stream client that connects to the external
beyla-k8s-cacheservice.There are some TO-DOs that will be left for future PRs, as this feature will still remain officially unreleased and hidden from the documentation.
This PR also fixes a bug: if Beyla was running with host network, the host.id was not properly retrieved.