Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy make target #1189

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Add clang-tidy make target #1189

merged 1 commit into from
Sep 22, 2024

Conversation

rafaelroquetto
Copy link
Contributor

@rafaelroquetto rafaelroquetto commented Sep 20, 2024

  • add a new clang-tidy make target for convenience (which can then be referenced in the README - separate PR)
  • instead of filtering for warnings to error out, simply turn warnings into errors

@rafaelroquetto rafaelroquetto force-pushed the clang-tidy2 branch 2 times, most recently from b33d5b3 to 5c4f37f Compare September 20, 2024 20:18
@rafaelroquetto rafaelroquetto changed the title Clang tidy2 Add clang-tidy make target Sep 20, 2024
@rafaelroquetto rafaelroquetto marked this pull request as ready for review September 20, 2024 20:20
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

The test timeout is the usual stuff we are seeing. I wonder if we can temporarily increase it?

@rafaelroquetto
Copy link
Contributor Author

@grcevski I will wait to see if anything changes over the weekend, and do it otherwise. It's really strange this has started in the past days.

@rafaelroquetto rafaelroquetto merged commit 9a13e73 into main Sep 22, 2024
11 checks passed
@rafaelroquetto rafaelroquetto deleted the clang-tidy2 branch September 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants