-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clang-tidy on ebpf code #1180
Conversation
3e9343d
to
e83ec28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 81.12% 81.19% +0.06%
==========================================
Files 136 136
Lines 11497 11497
==========================================
+ Hits 9327 9335 +8
+ Misses 1639 1633 -6
+ Partials 531 529 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f564c3c
to
108550b
Compare
108550b
to
90a2bba
Compare
90a2bba
to
45e8c51
Compare
ae27abf
to
72c58c5
Compare
72c58c5
to
4744618
Compare
4744618
to
72350ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
This PR enables the use of
clang-tidy
to lint the code in thebpf/
directory. In a nutshell:.clang-tidy
configuration. Not all checks are enabled at this time. Because it will take time to address the issues that come up when new checks are enabled, these will be done on a staggered fashion;.clang-tidy
configuration - the source files inside thebpf/
directory have been linted and adjusted to ensure the current checks pass. Files inside theheaders/
directory are mostly ignored (speciallyvmlinux.h
as they are both problematic and auto-generated.clang-tidy
. Because the vanilla clang-tidy package that ships with the runner is out of date (and unable to parse our configuration file), we fetch the latest clang binaries directly from the LLVM apt repositories.Another PR will follow shortly documenting the usage of
clang-format
andclang-tidy
on theREADME
file.