Skip to content

Commit

Permalink
Default metrics expiration TTL to 70 minutes (#1555)
Browse files Browse the repository at this point in the history
  • Loading branch information
mariomac authored Jan 22, 2025
1 parent d53deed commit eefe02a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions pkg/beyla/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const (
)

const (
defaultMetricsTTL = 5 * time.Minute
defaultMetricsTTL = 70 * time.Minute
)

var DefaultConfig = Config{
Expand Down Expand Up @@ -75,8 +75,6 @@ var DefaultConfig = Config{
Instrumentations: []string{
instrumentations.InstrumentationALL,
},
// TODO: keep OTEL expiration disabled by default until we address
// this issue: https://github.com/grafana/beyla/issues/1065
TTL: defaultMetricsTTL,
},
Traces: otel.TracesConfig{
Expand Down
2 changes: 1 addition & 1 deletion pkg/beyla/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ network:
instrumentations.InstrumentationALL,
},
HistogramAggregation: "base2_exponential_bucket_histogram",
TTL: defaultMetricsTTL,
TTL: 5 * time.Minute,
},
Traces: otel.TracesConfig{
Protocol: otel.ProtocolUnset,
Expand Down

0 comments on commit eefe02a

Please sign in to comment.