fix: resolve race condition in prometheus.receive_http test
#4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add thread-safe getter methods for `server` and `args` fields to prevent race condition in `TestServerRestarts`. The test was accessing these fields without proper synchronization while `Update()` modified them under lock, causing intermittent failures.
cristiangreco
force-pushed
the
cristian/test-fix-race-http-receiver
branch
from
73d606c to
bb8896f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add thread-safe getter methods for
serverandargsfields to prevent race condition inTestServerRestarts. The test was accessing these fields without proper synchronization whileUpdate()modified them under lock, causing intermittent failures.Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist