Reapply Prometheus upgrade and fix ckit & upstream issue #4671
+902
−817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
added
the
publish-dev:linux
|
This seems to have fixed the clustering issues, but we now seem to have ran into this problem: prometheus/prometheus#17384 |
thampiotr
force-pushed
the
thampiotr/fix-ckit-for-prom-upgrade
branch
from
0775564 to
7b60b33
Compare
thampiotr
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Prometheus to version v3.7.3 (from v3.4.2) and updates the Prometheus dependency from github.com/prometheus/prometheus to a Grafana fork. The key changes include:
- Upgrading to Prometheus v3.7.3 which introduces the
slicelabelsbuild tag for a new label storage implementation - Adding the
slicelabelsbuild tag to all build configurations and test workflows - Updating various dependency versions (Loki, OTel Collector, cloud SDKs, etc.)
- Adapting code to API changes in Prometheus v3.7.3 (decoder initialization, validation scheme types, etc.)
Reviewed Changes
Copilot reviewed 57 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod, go.sum | Update dependencies including Prometheus fork, Loki, OTel Collector components, and cloud SDKs |
| Makefile, Dockerfiles | Add slicelabels build tag to all build targets |
| .github/workflows/*.yml | Add slicelabels tag to all test and build workflows |
| .golangci.yml | Configure linter to use slicelabels build tag |
| internal/component/common/loki/client/*.go | Implement build-tag-specific label conversion for slicelabels support |
| internal/static/metrics/wal/*.go | Update Prometheus decoder initialization with new API |
| internal/component/prometheus/*.go | Adapt to Prometheus validation scheme API changes |
| internal/static/config/*.go | Update validation scheme and escaping scheme configurations |
thampiotr
added
publish-dev:linux
|
Tested this image in one of internal clusters and it's been good! |
kgeckhart
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist