Change log level in eventlogmessage #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
approved these changes
Jan 3, 2025
dehaansa
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
It's common in windows messages to have lines that don't follow the key:value format. There should not be a warning for these.
Changing the log-level and updating the doc is only a first step. The next step would be to improving the parser to not lose the info that does not follow the key:value format (such as the description) and support multi-lines value for the key:value pairs
Which issue(s) this PR fixes
Fixes #982
Follow up issue to improve this stage: #2337
Notes to the Reviewer
PR Checklist