prometheus.operator.*: allow setting informer_sync_timeout #2161
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
reviewed
Nov 26, 2024
| @@ -34,6 +34,7 @@ Name | Type | Description | Default | Required | |||
| ---- | ---- | ----------- | ------- | -------- | |||
| `forward_to` | `list(MetricsReceiver)` | List of receivers to send scraped metrics to. | | yes | |||
| `namespaces` | `list(string)` | List of namespaces to search for PodMonitor resources. If not specified, all namespaces will be searched. || no | |||
| `informer_sync_timeout` | `duration` | Timeout for initial sync of PodMonitor resources. | `1m` | no | |||
There was a problem hiding this comment.
If it's for the initial sync, should it be called initial_sync_timeout? Is "informer" a k8s term?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #2004
Notes to the Reviewer
PR Checklist