Updated pod labels to include all labels #2071
Open
+109
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Bourque <[email protected]>
|
@petewall Is there anything specific I need to get this PR to continue its workflow? It's been stuck for a couple of days now at the continuous-integration step and when I click Details it just says to contact the repo admin. :( If there's something I'm missing from my PR, I'm more than happy to address that. Thanks!!! |
|
I approved and kicked off the build. |
|
Thanks @mattdurham!!! It looks like I needed to run a script to update the tests. I'm guessing that's why it failed at the previous step, but I think it should be good now. |
|
@petewall Any chance you or someone else can take a look at this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updates the _pod.yaml file to include the same labels used in the DaemonSet/StatefulSet/Deployment to help improve traceability throughout the application. The new labels include the selectorLabels which it was previously using so this should only be adding additional labels and not removing any.
Which issue(s) this PR fixes
#2070
#issue_id
Notes to the Reviewer
PR Checklist