-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): ensure helm resources have correct namespace #2044
base: main
Are you sure you want to change the base?
Conversation
@petewall another small helm chart PR if you have time |
I get nervous about the removal of the use of the |
7b622fa
to
64d1ad6
Compare
Didn't seem that was the case considering that it was undocumented value and some resources were already using the But updated the PR regardless. |
47bb24c
to
41f80bc
Compare
I resolved the conflict, please review. For now I'm using my local fork as a workaround. |
@shinebayar-g There are some generated files that need a poke... if you run |
dd906c9
to
e2ee287
Compare
Thanks @clayton-cornell , I've updated the PR as requested and rebased. |
PR Description
Helm chart resources don't have correct namespaces.
Which issue(s) this PR fixes
Issue can be reproduced by running
helm template --namespace alloy alloy grafana/alloy --version 0.9.2
.Generated yaml files didn't have correct namespace.
Notes to the Reviewer
PR Checklist