Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): ensure helm resources have correct namespace #2044

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shinebayar-g
Copy link

@shinebayar-g shinebayar-g commented Nov 5, 2024

PR Description

Helm chart resources don't have correct namespaces.

Which issue(s) this PR fixes

Issue can be reproduced by running helm template --namespace alloy alloy grafana/alloy --version 0.9.2.
Generated yaml files didn't have correct namespace.

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@shinebayar-g shinebayar-g requested a review from a team as a code owner November 5, 2024 22:30
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

@wildum
Copy link
Contributor

wildum commented Nov 6, 2024

@petewall another small helm chart PR if you have time

@petewall
Copy link
Contributor

petewall commented Nov 6, 2024

I get nervous about the removal of the use of the alloy.namespace template function. That might break some users.
Perhaps instead of using .Release.namespace, we use alloy.namespace which is enabled by the namespaceOverride value

@shinebayar-g
Copy link
Author

I get nervous about the removal of the use of the alloy.namespace template function. That might break some users. Perhaps instead of using .Release.namespace, we use alloy.namespace which is enabled by the namespaceOverride value

Didn't seem that was the case considering that it was undocumented value and some resources were already using the {{ .Release.Namespace }} like in the operations/helm/charts/alloy/templates/pdb.yaml file.

But updated the PR regardless.

@shinebayar-g shinebayar-g force-pushed the fix-alloy-namespace branch 2 times, most recently from 47bb24c to 41f80bc Compare November 16, 2024 03:34
@shinebayar-g
Copy link
Author

shinebayar-g commented Nov 16, 2024

I resolved the conflict, please review. For now I'm using my local fork as a workaround.

@clayton-cornell
Copy link
Contributor

@shinebayar-g There are some generated files that need a poke... if you run make generate-helm-docs and make generate-helm-tests, and then push the changes, the Test Helm chart tests should pass.

@shinebayar-g shinebayar-g force-pushed the fix-alloy-namespace branch 2 times, most recently from dd906c9 to e2ee287 Compare November 18, 2024 21:25
@shinebayar-g
Copy link
Author

Thanks @clayton-cornell , I've updated the PR as requested and rebased.

@clayton-cornell
Copy link
Contributor

@petewall @wildum Is this PR ready to approve/merge?

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants