-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenShift docs #1861
base: main
Are you sure you want to change the base?
Add OpenShift docs #1861
Conversation
|
||
```yaml | ||
piVerison: aapps/v1 | ||
kind: DaemonSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few deployment modes that may apply here. Maybe we should give an example of one only and refer to https://grafana.com/docs/alloy/next/set-up/deploy/ for more info?
LMK what you think and I'll help iron out the details of this YAML, as I think it needs some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the most common deployment mode? Definitely agree, pick one and then provide links/info for the reader to adapt to their local needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thampiotr I've tweaked the topic a little and fixed a few typos etc. The main remaining issue is to fix up the YAML a bit. I'm not sure what needs to be done here....
@Toure If you have a chance, can you take a look through this draft and let me know if it looks OK... is it missing anything? |
Co-authored-by: Toure Dunnon <[email protected]>
Co-authored-by: Piotr <[email protected]>
PR Description
This PR adds OpenShift deployment instructions to the Alloy docs
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist