Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift docs #1861

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add OpenShift docs #1861

wants to merge 5 commits into from

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR adds OpenShift deployment instructions to the Alloy docs

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 9, 2024
docs/sources/set-up/install/openshift.md Outdated Show resolved Hide resolved

```yaml
piVerison: aapps/v1
kind: DaemonSet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few deployment modes that may apply here. Maybe we should give an example of one only and refer to https://grafana.com/docs/alloy/next/set-up/deploy/ for more info?

LMK what you think and I'll help iron out the details of this YAML, as I think it needs some changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the most common deployment mode? Definitely agree, pick one and then provide links/info for the reader to adapt to their local needs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thampiotr I've tweaked the topic a little and fixed a few typos etc. The main remaining issue is to fix up the YAML a bit. I'm not sure what needs to be done here....

@clayton-cornell
Copy link
Contributor Author

@Toure If you have a chance, can you take a look through this draft and let me know if it looks OK... is it missing anything?

@clayton-cornell clayton-cornell marked this pull request as ready for review November 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants