Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates snowflake prometheus exporter (with NULL fix) #6929

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

StefanKurek
Copy link
Contributor

PR Description

Updates Snowflake Prometheus Exporter to latest version (with NULL fix)

Which issue(s) this PR fixes

https://github.com/grafana/support-escalations/issues/10637

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @StefanKurek!

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same remark as in alloy

CHANGELOG.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

@Dasomeone
Copy link
Member

@wildum can you merge this once the tests have run through please? It never got merged originally and the related support escalation got reopened

@thampiotr thampiotr merged commit fc50e95 into grafana:main Jun 19, 2024
10 checks passed
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jul 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants