Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.38] Replace docs/reference shortcode with ref URIs #6887

Merged
merged 4 commits into from
May 22, 2024

Conversation

jdbaldry
Copy link
Member

You can use ref URIs in admonitions (or any shortcodes) because they are inline and not subject to the issues noted in the admonition shortcode.

The ref URIs perform the same pattern matching as docs/reference but don't require the use of reference-style links and the destinations are ordinary (full) URLs that can include version substitution. Unlike docs/reference, the implementation doesn't use relref so you don't have to be careful with omitting trailing slashes and the links will follow redirects.

Documentation: https://grafana.com/docs/writers-toolkit/write/links/#link-from-source-content-thats-used-in-multiple-projects

To check the links, refer to the deploy preview in https://github.com/grafana/website/pull/19630.

Signed-off-by: Jack Baldry [email protected]

@jdbaldry jdbaldry added the type/docs Docs Squad label across all Grafana Labs repos label Apr 30, 2024
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
(cherry picked from commit 7b41d2a)
Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry marked this pull request as ready for review May 20, 2024 08:56
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clayton-cornell clayton-cornell merged commit 5049a7a into release-v0.38 May 22, 2024
9 of 10 checks passed
@clayton-cornell clayton-cornell deleted the jdb/2024-04-use-ref-uris-v0.38 branch May 22, 2024 14:42
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jun 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants