Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: reexpose static for public import #6842

Merged
merged 1 commit into from
Apr 10, 2024
Merged

misc: reexpose static for public import #6842

merged 1 commit into from
Apr 10, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 10, 2024

Everything was moved to internal/ for the 1.0 release, but there are some code dependencies which depend on static mode. Now that the 1.0 release is completed, the static mode code can be reexported to not break those teams (though the package paths have still changed).

Note that there is no plans at this time for this change to be reflected in Alloy.

@rfratto rfratto requested a review from jcreixell April 10, 2024 18:52
Everything was moved to internal/ for the 1.0 release, but there are
some code dependencies which depend on static mode. Now that the 1.0
release is completed, the static mode code can be reexported.

Note that there is no plans at this time for this change to be reflected
in Alloy.
@rfratto rfratto merged commit a41bbad into main Apr 10, 2024
10 checks passed
@rfratto rfratto deleted the re-expose-static branch April 10, 2024 19:10
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants