Experiment in pruning unused exporters #6823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SandersAaronD
changed the title
SandersAaronD
force-pushed
the
pruning-experiment
branch
from
eed8ea9
to
81b8fd3
Compare
rfratto
added
variant/static
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft to get a clean diff I can share, this isn't a real proposal of any kind that anyone should ever consider merging.
Likely want to do a local build and prune off most of the exporters as unused to minimize file size, this branch prunes a lot of them but some still appear to be bundled into the binary when running "go tool nm -size -sort size" on it (eg, the oracle exporter is still in there). That output is 30mb so I can't upload it but available on request.
My best guess is that there are other stray references to the pruned exporters hanging around and I just haven't found them yet, which makes this actually a fantastically uninteresting diff and not that important for anyone to look at. Thanks @rfratto for pointing me in the right direction.